Page MenuHomePhabricator
Differential D16750

Update Phortune Merchant to EditEngine
ClosedPublic
Actions

Authored by chad on Oct 25 2016, 10:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 2:39 AM
Unknown Object (File)
Sun, Feb 9, 2:39 AM
Unknown Object (File)
Sun, Feb 9, 2:39 AM
Unknown Object (File)
Sun, Feb 9, 2:39 AM
Unknown Object (File)
Tue, Feb 4, 11:25 AM
Unknown Object (File)
Sat, Feb 1, 2:42 AM
Unknown Object (File)
Wed, Jan 29, 5:40 AM
Unknown Object (File)
Tue, Jan 28, 1:59 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP0c9ecf835166: Update Phortune Merchant to EditEngine
Summary

Converts PhortuneMerchant to EditEngine.

Test Plan

Edits existing merchants fine, same issue as Conpherence when making new ones with permissions.

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D16750
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14265
Build 18554: Run Core Tests
Build 18553: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40342.Oct 25 2016, 10:56 PM
chad retitled this revision from to Update Phortune Merchant to EditEngine.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 25 2016, 10:56 PM
epriestley edited edge metadata.Oct 26 2016, 12:09 AM

I'll send you a counterdiff for the policy.

src/applications/phortune/application/PhabricatorPhortuneApplication.php
85–87

This should be unnecessary.

epriestley mentioned this in D16764: Improve some setInitialValue() behavior for PhortuneMerchants.Oct 28 2016, 8:29 PM
epriestley accepted this revision.Oct 28 2016, 8:42 PM
epriestley edited edge metadata.

Seems to work with the addition of D16764.

This revision is now accepted and ready to land.Oct 28 2016, 8:42 PM
chad added inline comments.Oct 28 2016, 8:50 PM
src/applications/phortune/editor/PhortuneMerchantEditEngine.php
91

😭

epriestley added a comment.Oct 28 2016, 8:51 PM

oh you expect me to READ the code?!?!

chad updated this revision to Diff 40375.Oct 28 2016, 9:14 PM
chad edited edge metadata.
  • spelling, rebase
Closed by commit rP0c9ecf835166: Update Phortune Merchant to EditEngine (authored by chad, committed by chad). · Explain WhyOct 28 2016, 9:15 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rP2bbddb8c0f29: Improve some setInitialValue() behavior for PhortuneMerchants.Oct 28 2016, 9:54 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
phortune/
application/
3 lines
controller/
193 lines
editor/
120 lines
storage/
1 line

Diff 40375

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phortune/application/PhabricatorPhortuneApplication.php

Loading...
View Options

src/applications/phortune/controller/PhortuneMerchantEditController.php

Loading...
View Options

src/applications/phortune/editor/PhortuneMerchantEditEngine.php

Loading...
View Options

src/applications/phortune/storage/PhortuneMerchant.php

Loading...
Phabricator · Built by Phacility