Page MenuHomePhabricator

Make event invitees behave a little better for stub/ghost events
ClosedPublic

Authored by epriestley on Oct 27 2016, 5:21 PM.
Tags
None
Referenced Files
F15461263: D16758.id.diff
Tue, Apr 1, 6:47 AM
F15456989: D16758.diff
Sun, Mar 30, 1:29 PM
F15447348: D16758.id40365.diff
Thu, Mar 27, 11:16 PM
F15440581: D16758.id40361.diff
Wed, Mar 26, 1:39 PM
F15439933: D16758.id.diff
Wed, Mar 26, 10:21 AM
F15435002: D16758.diff
Tue, Mar 25, 6:20 AM
F15432495: D16758.id40361.diff
Mon, Mar 24, 6:20 PM
F15410021: D16758.id40361.diff
Wed, Mar 19, 6:41 AM
Subscribers
None

Details

Summary

Ref T11326. Currently:

  • The month view and day view (ghosts) don't show that you're invited to a child event.
  • The detail view copies the invite list, including attending status, but only after it shows the page for the first time.

Instead, for now, just do this:

  • Ghosts/stubs use the parent invite list, but treat everyone as "invited".
  • Materializing a stub just saves the list as-is (i.e., invited, not a copy of attending/declined/etc).

This behavior may need some refining eventually but is at least reasonable (not obviously bad/buggy).

Test Plan
  • Viewed month/day views, now shown as "invited".
  • Viewed detail view, now invitee list shows up properly.

Diff Detail

Repository
rP Phabricator
Branch
cimport1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14250
Build 18532: Run Core Tests
Build 18531: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make event invitees behave a little better for stub/ghost events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 27 2016, 6:26 PM
This revision was automatically updated to reflect the committed changes.