Page MenuHomePhabricator

Fix a Phortune bug where an invalid viewer could sometimes be selected for billing a subscription
ClosedPublic

Authored by epriestley on Oct 26 2016, 10:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 2, 8:00 PM
Unknown Object (File)
Sun, Feb 9, 2:40 AM
Unknown Object (File)
Sun, Feb 9, 2:40 AM
Unknown Object (File)
Sun, Feb 9, 2:40 AM
Unknown Object (File)
Sun, Feb 9, 2:40 AM
Unknown Object (File)
Feb 2 2025, 2:58 AM
Unknown Object (File)
Jan 25 2025, 4:08 AM
Unknown Object (File)
Jan 24 2025, 11:41 PM
Subscribers
None

Details

Summary

A live instance hit the scenario described in the comment, where an out-of-date user was being selected as the actor.

Since they were no longer an account member, they could not see the payment method and autopay was failing.

Instead, select a relatively arbitrary user who is a current, valid, non-disabled member.

Test Plan

Ran subscriptions with bin/worker execute ..., saw it select a valid actor.

Diff Detail

Repository
rP Phabricator
Branch
phortune1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14248
Build 18529: Run Core Tests
Build 18528: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a Phortune bug where an invalid viewer could sometimes be selected for billing a subscription.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2016, 10:53 PM
This revision was automatically updated to reflect the committed changes.