Page MenuHomePhabricator

Fix a Phortune bug where an invalid viewer could sometimes be selected for billing a subscription
ClosedPublic

Authored by epriestley on Oct 26 2016, 10:51 PM.
Tags
None
Referenced Files
F18109665: D16757.id40360.diff
Mon, Aug 11, 3:03 PM
F18105928: D16757.id.diff
Sun, Aug 10, 8:35 PM
F18105850: D16757.diff
Sun, Aug 10, 8:04 PM
F18103035: D16757.id.diff
Sun, Aug 10, 1:13 AM
F18101652: D16757.id40359.diff
Sat, Aug 9, 2:37 PM
F18098814: D16757.diff
Fri, Aug 8, 11:12 PM
F17820231: D16757.id40359.diff
Jul 26 2025, 1:52 AM
F17818942: D16757.id.diff
Jul 26 2025, 12:48 AM
Subscribers
None

Details

Summary

A live instance hit the scenario described in the comment, where an out-of-date user was being selected as the actor.

Since they were no longer an account member, they could not see the payment method and autopay was failing.

Instead, select a relatively arbitrary user who is a current, valid, non-disabled member.

Test Plan

Ran subscriptions with bin/worker execute ..., saw it select a valid actor.

Diff Detail

Repository
rP Phabricator
Branch
phortune1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14248
Build 18529: Run Core Tests
Build 18528: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a Phortune bug where an invalid viewer could sometimes be selected for billing a subscription.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2016, 10:53 PM
This revision was automatically updated to reflect the committed changes.