Page MenuHomePhabricator
Differential D16738

Write a basic SSH pull log for Git
ClosedPublic
Actions

Authored by epriestley on Oct 20 2016, 6:32 PM.
Tags
None
Referenced Files
F14352708: D16738.diff
Thu, Dec 19, 2:40 PM
Unknown Object (File)
Fri, Dec 13, 4:31 AM
Unknown Object (File)
Fri, Dec 13, 3:34 AM
Unknown Object (File)
Tue, Dec 10, 6:37 PM
Unknown Object (File)
Nov 19 2024, 1:59 AM
Unknown Object (File)
Nov 10 2024, 7:26 PM
Unknown Object (File)
Nov 8 2024, 9:16 AM
Unknown Object (File)
Nov 8 2024, 7:34 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11766: Write to the pull log from SSH, not just HTTP
Commits
rP272046ae7701: Write a basic SSH pull log for Git
Summary

Ref T11766. When users run git pull or similar, log the operation in the pull log.

Test Plan

Performed SSH pulls, got a log in the database. Today, this event log is purely diagnostic and has no UI.

Diff Detail

Repository
rP Phabricator
Branch
pull1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/ssh/DiffusionGitUploadPackSSHWorkflow.php:72XHP16TODO Comment
Advicesrc/infrastructure/ssh/PhabricatorSSHWorkflow.php:92XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14197
Build 18451: Run Core Tests
Build 18450: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40305.Oct 20 2016, 6:32 PM
epriestley retitled this revision from to Write a basic SSH pull log for Git.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11766: Write to the pull log from SSH, not just HTTP.
chad accepted this revision.Oct 20 2016, 7:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2016, 7:36 PM
Closed by commit rP272046ae7701: Write a basic SSH pull log for Git (authored by epriestley, committed by epriestley). · Explain WhyOct 20 2016, 8:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
ssh/
25 lines
18 lines
infrastructure/
ssh/
15 lines

Diff 40305

View Options

src/applications/diffusion/ssh/DiffusionGitUploadPackSSHWorkflow.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

Loading...
View Options

src/infrastructure/ssh/PhabricatorSSHWorkflow.php

Loading...
Phabricator · Built by Phacility