Page MenuHomePhabricator
Differential D16725

Don't show participants in Conpherence left open on mobile
ClosedPublic
Actions

Authored by chad on Oct 19 2016, 4:51 AM.
Tags
None
Referenced Files
F14061722: D16725.diff
Mon, Nov 18, 8:16 AM
F14060656: D16725.diff
Mon, Nov 18, 2:42 AM
F14048734: D16725.diff
Thu, Nov 14, 9:27 AM
F14039793: D16725.id40276.diff
Mon, Nov 11, 6:20 AM
F14036480: D16725.diff
Sun, Nov 10, 10:25 AM
F14021034: D16725.diff
Wed, Nov 6, 4:48 AM
F14018142: D16725.id40276.diff
Tue, Nov 5, 5:15 AM
F14010279: D16725.id40276.diff
Thu, Oct 31, 6:51 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T11764: Participant list stuck on top of chat history on mobile device
Commits
rP89f0015ae6ec: Don't show participants in Conpherence left open on mobile
Summary

Fixes T11764. Moves rendering of the column to client-side, which can skip if it detects we're on mobile.

Test Plan

Open column on desktop, switch to mobile, don't see column. Toggle column on mobile on and off. Switch back to desktop.

Diff Detail

Repository
rP Phabricator
Branch
toggle-css (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14169
Build 18406: Run Core Tests
Build 18405: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40276.Oct 19 2016, 4:51 AM
chad retitled this revision from to Don't show participants in Conpherence left open on mobile.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T11764: Participant list stuck on top of chat history on mobile device.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 19 2016, 4:51 AM
epriestley accepted this revision.Oct 19 2016, 3:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 19 2016, 3:14 PM
Closed by commit rP89f0015ae6ec: Don't show participants in Conpherence left open on mobile (authored by chad, committed by chad). · Explain WhyOct 19 2016, 3:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
52 lines
src/
applications/
conpherence/
view/
23 lines
webroot/
rsrc/
js/
application/
conpherence/
34 lines
22 lines

Diff 40276

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceLayoutView.php

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-toggle-widget.js

Loading...
Phabricator · Built by Phacility