Differential D16711

Remove imagePHIDs column from ConpherenceThread
ClosedPublic
Actions

Authored by chad on Oct 16 2016, 3:29 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T11730: Remove image crop from Conpherence

Commits

rPdd25b2b48bae: Remove imagePHIDs column from ConpherenceThread

Summary

Ref T11730. Removes the unused column, seen no issues during past week migrations.

Test Plan

Run migration, check database no longer contains column.

Diff Detail

Repository

rP Phabricator

Branch

remove-image-phids (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14133
Build 18352: Run Core Tests
Build 18351: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40240.Oct 16 2016, 3:29 PM

chad retitled this revision from to Remove imagePHIDs column from ConpherenceThread.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11730: Remove image crop from Conpherence.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 16 2016, 3:29 PM

epriestley accepted this revision.Oct 17 2016, 10:37 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 17 2016, 10:37 PM

epriestley awarded a token.Oct 17 2016, 10:37 PM

Closed by commit rPdd25b2b48bae: Remove imagePHIDs column from ConpherenceThread (authored by chad, committed by chad). · Explain WhyOct 17 2016, 10:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20161016.conpherence.imagephids.sql

2 lines

src/

applications/

conpherence/

storage/

ConpherenceThread.php

2 lines

Diff 40240

View Options

resources/sql/autopatches/20161016.conpherence.imagephids.sql