Page MenuHomePhabricator
Differential D16707

Fix Conphernce sometimes searching wrong room
ClosedPublic
Actions

Authored by chad on Oct 14 2016, 4:27 PM.
Tags
None
Referenced Files
F13103379: D16707.diff
Sat, Apr 27, 10:29 AM
Unknown Object (File)
Thu, Apr 18, 11:14 PM
Unknown Object (File)
Wed, Apr 17, 2:28 PM
Unknown Object (File)
Mon, Apr 15, 9:07 AM
Unknown Object (File)
Fri, Apr 12, 9:33 AM
Unknown Object (File)
Thu, Apr 11, 6:55 AM
Unknown Object (File)
Mon, Apr 1, 10:52 PM
Unknown Object (File)
Sun, Mar 31, 1:04 AM
View All 93 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T3165: Provide Search in Conpherence
Commits
rP52dd354dad1e: Fix Conphernce sometimes searching wrong room
Summary

I passed this in as a config, but need to parse it live when threads change, otherwise the wrong room could be searched.

Test Plan

Search in one room, click a second, search again, see correct results.

Diff Detail

Repository
rP Phabricator
Branch
searchbar-bug (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14120
Build 18330: Run Core Tests
Build 18329: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40227.Oct 14 2016, 4:27 PM
chad retitled this revision from to Fix Conphernce sometimes searching wrong room.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 14 2016, 4:27 PM
epriestley accepted this revision.Oct 14 2016, 4:37 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 14 2016, 4:37 PM
Closed by commit rP52dd354dad1e: Fix Conphernce sometimes searching wrong room (authored by chad, committed by chad). · Explain WhyOct 14 2016, 4:38 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T3165: Provide Search in Conpherence.Oct 15 2016, 2:42 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
applications/
conpherence/
controller/
7 lines
webroot/
rsrc/
js/
application/
conpherence/
5 lines

Diff 40227

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceController.php

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-conpherence-search.js

Loading...
Phabricator · Built by Phacility