Page MenuHomePhabricator
Differential D16702

Support disabling calendar imports
ClosedPublic
Actions

Authored by epriestley on Oct 13 2016, 3:33 PM.
Tags
None
Referenced Files
F14316264: D16702.diff
Wed, Dec 18, 7:03 AM
F14316092: D16702.diff
Wed, Dec 18, 6:52 AM
F14300815: D16702.id40209.diff
Tue, Dec 17, 5:25 PM
Unknown Object (File)
Thu, Dec 12, 7:48 AM
Unknown Object (File)
Thu, Dec 12, 5:57 AM
Unknown Object (File)
Mon, Dec 9, 11:36 PM
Unknown Object (File)
Sun, Dec 8, 2:25 PM
Unknown Object (File)
Sun, Dec 8, 5:38 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rP6e2a86470b47: Support disabling calendar imports
Summary

Ref T10747. This doesn't do much for ICS file imports (you can't disable them since it doesn't do anything meaningful) but will matter more for ICS-subscription imports later.

Test Plan

Clicked "Disable" on an ICS file import, got explanatory dialog.

Diff Detail

Repository
rP Phabricator
Branch
cimport4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14098
Build 18296: Run Core Tests
Build 18295: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40205.Oct 13 2016, 3:33 PM
epriestley retitled this revision from to Support disabling calendar imports.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Oct 13 2016, 3:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2016, 3:59 PM
Closed by commit rP6e2a86470b47: Support disabling calendar imports (authored by epriestley, committed by epriestley). · Explain WhyOct 13 2016, 4:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40205

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarImportDisableController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarImportViewController.php

Loading...
View Options

src/applications/calendar/import/PhabricatorCalendarICSImportEngine.php

Loading...
View Options

src/applications/calendar/import/PhabricatorCalendarImportEngine.php

Loading...
Phabricator · Built by Phacility