Differential D16699

Make Calendar ICS imports sort of work in a crude, approximate way
ClosedPublic
Actions

Authored by epriestley on Oct 12 2016, 8:46 PM.

Tags

None

Referenced Files

	F14063323: D16699.diff
	Mon, Nov 18, 5:48 PM

	F14018561: D16699.id40197.diff
	Tue, Nov 5, 4:18 PM

	F14008571: D16699.diff
	Wed, Oct 30, 1:21 AM

	F13967580: D16699.id40197.diff
	Oct 16 2024, 2:35 PM

	F13966332: D16699.id.diff
	Oct 16 2024, 7:35 AM

	F13956426: D16699.id40199.diff
	Oct 14 2024, 5:35 AM

	Unknown Object (File)
	Oct 9 2024, 5:14 AM

	Unknown Object (File)
	Sep 27 2024, 2:58 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rP86a00ee4abd6: Make Calendar ICS imports sort of work in a crude, approximate way

Summary

Ref T10747. This barely works, but can technically import some event data.

Test Plan

Used import flow to import a ".ics" document.

Diff Detail

Repository

Branch

cimport2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/calendar/import/PhabricatorCalendarImportEngine.php:43	XHP16	TODO Comment
Advice	src/applications/calendar/import/PhabricatorCalendarImportEngine.php:58	XHP16	TODO Comment
Advice	src/applications/calendar/import/PhabricatorCalendarImportEngine.php:59	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 14090
Build 18283: Run Core Tests
Build 18282: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40197.Oct 12 2016, 8:46 PM

epriestley retitled this revision from to Make Calendar ICS imports sort of work in a crude, approximate way.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 12 2016, 9:23 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 12 2016, 9:23 PM

Closed by commit rP86a00ee4abd6: Make Calendar ICS imports sort of work in a crude, approximate way (authored by epriestley, committed by epriestley). · Explain WhyOct 12 2016, 10:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

22 lines

aphront/

httpparametertype/

AphrontFileHTTPParameterType.php

60 lines

applications/

calendar/

controller/

PhabricatorCalendarImportEditController.php

92 lines

PhabricatorCalendarImportListController.php

13 lines

PhabricatorCalendarImportViewController.php

130 lines

editor/

PhabricatorCalendarImportEditEngine.php

115 lines

PhabricatorCalendarImportEditor.php

24 lines

import/

PhabricatorCalendarICSImportEngine.php

74 lines

PhabricatorCalendarImportEngine.php

68 lines

query/

PhabricatorCalendarEventQuery.php

4 lines

PhabricatorCalendarImportQuery.php

18 lines

PhabricatorCalendarImportSearchEngine.php

2 lines

storage/

PhabricatorCalendarEvent.php

63 lines

PhabricatorCalendarImport.php

35 lines

xaction/

PhabricatorCalendarImportDisableTransaction.php

28 lines

PhabricatorCalendarImportICSFileTransaction.php

86 lines

PhabricatorCalendarImportNameTransaction.php

39 lines

PhabricatorCalendarImportTransactionType.php

4 lines

transactions/

editfield/

PhabricatorFileEditField.php

23 lines

Diff 40197

src/__phutil_library_map__.php

Loading...

src/aphront/httpparametertype/AphrontFileHTTPParameterType.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarImportEditController.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarImportListController.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarImportViewController.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarImportEditEngine.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarImportEditor.php

Loading...

src/applications/calendar/import/PhabricatorCalendarICSImportEngine.php

Loading...

src/applications/calendar/import/PhabricatorCalendarImportEngine.php

Loading...

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...

src/applications/calendar/query/PhabricatorCalendarImportQuery.php

Loading...

src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarImport.php

Loading...

src/applications/calendar/xaction/PhabricatorCalendarImportDisableTransaction.php

Loading...

src/applications/calendar/xaction/PhabricatorCalendarImportICSFileTransaction.php

Loading...

src/applications/calendar/xaction/PhabricatorCalendarImportNameTransaction.php

Loading...

src/applications/calendar/xaction/PhabricatorCalendarImportTransactionType.php

Loading...

src/applications/transactions/editfield/PhabricatorFileEditField.php

Loading...