Page MenuHomePhabricator
Differential D16670

Convert Calendar Events to use RRULE frequency constants in various other places
ClosedPublic
Actions

Authored by epriestley on Oct 5 2016, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 7:21 PM
Unknown Object (File)
Mon, Nov 18, 1:08 AM
Unknown Object (File)
Thu, Nov 14, 3:49 AM
Unknown Object (File)
Sun, Nov 10, 5:05 AM
Unknown Object (File)
Tue, Nov 5, 8:52 PM
Unknown Object (File)
Thu, Oct 31, 11:34 AM
Unknown Object (File)
Oct 24 2024, 4:14 AM
Unknown Object (File)
Oct 21 2024, 9:27 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rP3164ff68db58: Convert Calendar Events to use RRULE frequency constants in various other places
Summary

Ref T10747.

  • Store recurrence as RRULEs internally.
  • Use RRULE constants.
  • Migrate existing rules to RRULEs.
Test Plan

Ran migration, nothing seemed broken?

Diff Detail

Repository
rP Phabricator
Branch
cal10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14018
Build 18180: Run Core Tests
Build 18179: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40128.Oct 5 2016, 6:26 PM
epriestley retitled this revision from to Convert Calendar Events to use RRULE frequency constants in various other places.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Oct 5 2016, 8:25 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 5 2016, 8:25 PM
Closed by commit rP3164ff68db58: Convert Calendar Events to use RRULE frequency constants in various other places (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 11:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
44 lines
src/
applications/
calendar/
controller/
19 lines
editor/
18 lines
storage/
59 lines
xaction/
74 lines

Diff 40128

View Options

resources/sql/autopatches/20161005.cal.01.rrules.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php

Loading...
Phabricator · Built by Phacility