Differential D16667

Mostly drive Calendar event recurrence with the RRULE engine
ClosedPublic
Actions

Authored by epriestley on Oct 5 2016, 4:53 PM.

Details

Reviewers

chad

Maniphest Tasks

T10737: Milestone project tags should inherit their parent project's tag colour

Commits

rP5dfb672a80f0: Mostly drive Calendar event recurrence with the RRULE engine

Summary

Ref T10737. Today, we evalute recurrence twice: once when querying, and once in all other cases. This converts the second case to use the RRULE engine.

Next up is making the query use the RRULE engine, too.

Test Plan

Created a new recurring event, iterated through it by clicking "next instance", viewed it on Calendar view.

Diff Detail

Repository

rP Phabricator

Branch

cal8

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/calendar/storage/PhabricatorCalendarEvent.php:832	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 14013
Build 18170: Run Core Tests
Build 18169: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40123.Oct 5 2016, 4:53 PM

epriestley retitled this revision from to Mostly drive Calendar event recurrence with the RRULE engine.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10737: Milestone project tags should inherit their parent project's tag colour.

chad accepted this revision.Oct 5 2016, 5:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 5 2016, 5:03 PM

Closed by commit rP5dfb672a80f0: Mostly drive Calendar event recurrence with the RRULE engine (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 10:57 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

query/

PhabricatorCalendarEventQuery.php

4 lines

storage/

PhabricatorCalendarEvent.php

104 lines

Diff 40123

View Options

src/applications/calendar/query/PhabricatorCalendarEventQuery.php