Differential D16666

Add Room Image to Conpherence header
ClosedPublic
Actions

Authored by chad on Oct 4 2016, 11:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 27, 12:59 AM

	Unknown Object (File)
	Thu, Apr 25, 2:22 AM

	Unknown Object (File)
	Fri, Apr 12, 2:22 PM

	Unknown Object (File)
	Thu, Apr 11, 9:44 AM

	Unknown Object (File)
	Mar 28 2024, 2:44 PM

	Unknown Object (File)
	Mar 15 2024, 9:54 PM

	Unknown Object (File)
	Mar 5 2024, 2:30 PM

	Unknown Object (File)
	Feb 4 2024, 11:24 PM

Subscribers

Details

Reviewers

Commits

rP02b5a2b39b79: Add Room Image to Conpherence header

Summary

This adds the room image to the main header in full Conpherence. It's nice, plus I plan to move the image edit workflow to it to simplify the move to EditEngine. I plan to build some default images for Conpherence which should be better about denoting the room, not just the last person writing.

Test Plan

Click on lots of rooms with and without topics.

Diff Detail

Repository

Branch

conph-header-img (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14010
Build 18166: Run Core Tests
Build 18165: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40120.Oct 4 2016, 11:18 PM

chad retitled this revision from to Add Room Image to Conpherence header.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 4 2016, 11:18 PM

epriestley accepted this revision.Oct 4 2016, 11:23 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 4 2016, 11:23 PM

Closed by commit rP02b5a2b39b79: Add Room Image to Conpherence header (authored by chad, committed by chad). · Explain WhyOct 4 2016, 11:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

applications/

conpherence/

controller/

ConpherenceController.php

2 lines

webroot/

rsrc/

css/

application/

conpherence/

header-pane.css

21 lines

Diff 40120

resources/celerity/map.php

Loading...

src/applications/conpherence/controller/ConpherenceController.php

Loading...

webroot/rsrc/css/application/conpherence/header-pane.css

Loading...