Paths

Table of Contentst

Differential D16665

Remove Crop Image from Conpherence Edit UI
ClosedPublic
Actions

Authored by chad on Oct 4 2016, 8:58 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T11730: Remove image crop from Conpherence

Commits

rP524906a4396a: Remove Crop Image from Conpherence Edit UI

Summary

Ref T11730. Removes the front end crop feature. Will follow up with proper removal, but this seems broken outright.

Test Plan

Edit a room, don't seen "Crop" feature. Upload new photo, works fine.

grep for ConpherencePicCropControl
grep for aphront-crop

Diff Detail

Repository

rP Phabricator

Branch

remove-crop (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14008
Build 18162: Run Core Tests
Build 18161: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40118.Oct 4 2016, 8:58 PM

chad retitled this revision from to Remove Crop Image from Conpherence Edit UI.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11730: Remove image crop from Conpherence.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 4 2016, 8:58 PM

I guess, remove code too

chad edited the test plan for this revision. (Show Details)Oct 4 2016, 9:06 PM

epriestley accepted this revision.Oct 4 2016, 11:22 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 4 2016, 11:22 PM

Closed by commit rP524906a4396a: Remove Crop Image from Conpherence Edit UI (authored by chad, committed by chad). · Explain WhyOct 4 2016, 11:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceUpdateController.php

4 lines

Diff 40118

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Remove Crop Image from Conpherence Edit UIClosedPublicActions