Paths

Table of Contentst

Differential D16660

Use most recent transaction in Conpherence notification menu
ClosedPublic
Actions

Authored by chad on Oct 4 2016, 4:17 AM.

Details

Reviewers

epriestley

Commits

rPa3b2e422fee8: Use most recent transaction in Conpherence notification menu

Summary

Not sure this ever worked correctly, but now once we have a supported action, skip the rest of the transactions. Currently you'll see a random old post.

Test Plan

Test multiple rooms in various states with new messages, edits, new room titles, etc.

Diff Detail

Repository

rP Phabricator

Branch

notif-menu-2 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13995
Build 18141: Run Core Tests
Build 18140: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40105.Oct 4 2016, 4:17 AM

chad retitled this revision from to Use most recent transaction in Conpherence notification menu.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 4 2016, 4:17 AM

chad updated this object.Oct 4 2016, 4:19 AM

epriestley accepted this revision.Oct 4 2016, 2:56 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/conpherence/storage/ConpherenceThread.php
291	Can we just `break;` instead of `continue`;? Could we just test `if ($message_transaction)` instead of using a separate `$has_item`?

This revision is now accepted and ready to land.Oct 4 2016, 2:56 PM

Closed by commit rPa3b2e422fee8: Use most recent transaction in Conpherence notification menu (authored by chad, committed by chad). · Explain WhyOct 4 2016, 3:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

storage/

ConpherenceThread.php

6 lines

Diff 40105

View Options

src/applications/conpherence/storage/ConpherenceThread.php

Use most recent transaction in Conpherence notification menuClosedPublicActions