Paths

Table of Contentst

Differential D16648

Support RRULE export in ICS from libphutil
ClosedPublic
Actions

Authored by epriestley on Oct 2 2016, 1:55 PM.

Tags

None

Referenced Files

	F14393689: D16648.id40142.diff
	Sun, Dec 22, 12:34 AM

	F14393688: D16648.id40080.diff
	Sun, Dec 22, 12:34 AM

	F14393687: D16648.id40079.diff
	Sun, Dec 22, 12:34 AM

	F14393666: D16648.id40142.diff
	Sun, Dec 22, 12:29 AM

	F14393640: D16648.id.diff
	Sun, Dec 22, 12:27 AM

	Unknown Object (File)
	Mon, Dec 16, 9:26 PM

	Unknown Object (File)
	Wed, Dec 11, 6:37 PM

	Unknown Object (File)
	Wed, Dec 11, 2:20 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU65eed1be889e: Support RRULE export in ICS from libphutil

Summary

Ref T10747. This formats RRULEs for export into ICS files.

Test Plan

Imported event into Calendar.app. Events appeared properly, except that the extra event in 2009 did not show up (apparently, Calendar.app does not support RDATE?).
Imported event into Google Calendar. Events appeared properly (including RDATE and EXDATE).

Diff Detail

Repository

Branch

cal1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13970
Build 18101: Run Core Tests
Build 18100: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40079.Oct 2 2016, 1:55 PM

epriestley retitled this revision from to Support RRULE export in ICS from libphutil.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

Also make getEpoch() on CalendarDateTime aware of all-day events.

chad accepted this revision.Oct 2 2016, 4:23 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 2 2016, 4:23 PM

Closed by commit rPHU65eed1be889e: Support RRULE export in ICS from libphutil (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 10:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarEventNode.php

51 lines

PhutilCalendarRecurrenceRule.php

196 lines

ics/

PhutilICSWriter.php

50 lines

__tests__/

PhutilICSWriterTestCase.php

33 lines

data/

writer-recurring-christmas.ics

16 lines

Diff 40079

src/parser/calendar/data/PhutilCalendarEventNode.php

Loading...

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

Loading...

src/parser/calendar/ics/PhutilICSWriter.php

Loading...

src/parser/calendar/ics/tests/PhutilICSWriterTestCase.php

Loading...

src/parser/calendar/ics/tests/data/writer-recurring-christmas.ics

Loading...