Page MenuHomePhabricator
Differential D16643

Add 'Persist Chat' option in Conpherence notification menu
ClosedPublic
Actions

Authored by chad on Oct 1 2016, 5:27 PM.
Tags
None
Referenced Files
F13149817: D16643.diff
Sat, May 4, 11:36 AM
Unknown Object (File)
Fri, May 3, 7:33 AM
Unknown Object (File)
Thu, Apr 25, 1:36 AM
Unknown Object (File)
Tue, Apr 16, 4:02 PM
Unknown Object (File)
Thu, Apr 11, 9:17 AM
Unknown Object (File)
Tue, Apr 9, 8:11 AM
Unknown Object (File)
Mar 29 2024, 8:00 AM
Unknown Object (File)
Mar 21 2024, 2:07 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP2f2126ecce08: Add 'Persist Chat' option in Conpherence notification menu
Summary

This exposes the chat window to a larger audience beside people who accidentaly hit \.

Test Plan

Lots of clicks and reloads.

pasted_file (114×422 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Branch
persist-chat (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13960
Build 18084: Run Core Tests
Build 18083: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40067.Oct 1 2016, 5:27 PM
chad retitled this revision from to Add 'Persist Chat' option in Conpherence notification menu.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 1 2016, 5:27 PM
chad edited the test plan for this revision. (Show Details)Oct 1 2016, 5:28 PM
epriestley accepted this revision.Oct 1 2016, 6:18 PM
epriestley edited edge metadata.

You're going to handle all the Quicksand bugs that get reported, right?

(This checkbox has the wrong state if you press \ too?)

This revision is now accepted and ready to land.Oct 1 2016, 6:18 PM
chad added a comment.Oct 1 2016, 6:21 PM

maybe remove the hotkey?

chad added a comment.Oct 1 2016, 6:25 PM

(removing hotkey)

epriestley added a comment.Oct 1 2016, 6:28 PM

Seems reasonable.

epriestley added a comment.Oct 1 2016, 6:28 PM

oh you didn't actually update it to

m8b need to ⌘+S

chad updated this revision to Diff 40069.Oct 1 2016, 6:31 PM
chad edited edge metadata.
  • remove hotkey
Closed by commit rP2f2126ecce08: Add 'Persist Chat' option in Conpherence notification menu (authored by chad, committed by chad). · Explain WhyOct 1 2016, 6:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
32 lines
src/
applications/
conpherence/
controller/
42 lines
webroot/
rsrc/
css/
application/
conpherence/
17 lines
js/
application/
conpherence/
7 lines

Diff 40069

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/notification.css

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-durable-column.js

Loading...
Phabricator · Built by Phacility