Differential D16634

Implement RFC5545 WEEKLY RRULE tests
ClosedPublic
Actions

Authored by epriestley on Sep 29 2016, 9:54 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU68bb2c62181d: Implement RFC5545 WEEKLY RRULE tests

Summary

Ref T10747. This needs some cleanup and I think probably still has some bugs but the tests pass, at least.

Test Plan

Unit tests now pass.

Diff Detail

Repository

rPHU libphutil

Branch

cal8

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/parser/calendar/data/PhutilCalendarRecurrenceRule.php:354	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 13931
Build 18042: Run Core Tests
Build 18041: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40042.Sep 29 2016, 9:54 PM

epriestley retitled this revision from to Implement RFC5545 WEEKLY RRULE tests.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 29 2016, 10:02 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 29 2016, 10:02 PM

Closed by commit rPHU68bb2c62181d: Implement RFC5545 WEEKLY RRULE tests (authored by epriestley, committed by epriestley). · Explain WhySep 29 2016, 11:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

254 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

107 lines

Diff 40042

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Implement RFC5545 WEEKLY RRULE testsClosedPublicActions