Page MenuHomePhabricator
Differential D16626

Add mobile upload button to Conpherence
ClosedPublic
Actions

Authored by chad on Sep 29 2016, 3:27 AM.
Tags
None
Referenced Files
F13162345: D16626.diff
Mon, May 6, 1:47 PM
Unknown Object (File)
Fri, May 3, 4:10 AM
Unknown Object (File)
Mon, Apr 29, 4:26 PM
Unknown Object (File)
Thu, Apr 25, 12:06 AM
Unknown Object (File)
Mon, Apr 22, 1:49 PM
Unknown Object (File)
Mon, Apr 22, 2:45 AM
Unknown Object (File)
Sat, Apr 13, 8:49 PM
Unknown Object (File)
Thu, Apr 11, 8:22 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T11622: In mobile Conpherence, provide a way to upload files
Commits
rP1095347832c9: Add mobile upload button to Conpherence
Summary

Fixes T11622. Moves the remarkup upload button into the text area on mobile/tablet.

Test Plan

Mobile/Tablet/Desktop Conpherence

Diff Detail

Repository
rP Phabricator
Branch
file-up (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13917
Build 18017: Run Core Tests
Build 18016: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40027.Sep 29 2016, 3:27 AM
chad retitled this revision from to Add mobile upload button to Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T11622: In mobile Conpherence, provide a way to upload files.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 29 2016, 3:27 AM
chad edited the test plan for this revision. (Show Details)Sep 29 2016, 3:29 AM
chad updated this revision to Diff 40028.Sep 29 2016, 3:35 AM
chad edited the test plan for this revision. (Show Details)
  • pixel
chad updated this revision to Diff 40029.Sep 29 2016, 3:45 AM
  • derp?
chad added a comment.Sep 29 2016, 3:50 AM

shipitquick

epriestley accepted this revision.Sep 29 2016, 4:11 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2016, 4:11 PM
Closed by commit rP1095347832c9: Add mobile upload button to Conpherence (authored by chad, committed by chad). · Explain WhySep 29 2016, 4:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
form/
control/
6 lines
webroot/
rsrc/
css/
application/
conpherence/
16 lines

Diff 40028

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/message-pane.css

Loading...
Phabricator · Built by Phacility