Differential D16616

Add many working RRULE test cases
ClosedPublic
Actions

Authored by epriestley on Sep 28 2016, 1:24 AM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU16cb15ae0c22: Add many working RRULE test cases

Summary

Ref T10747. Except for the BYSETPOS stuff, these all already work.

Test Plan

Unit tests pass.

Diff Detail

Repository

rPHU libphutil

Branch

cal14

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/parser/calendar/data/__tests__/PhutilCalendarRecurrenceRuleTestCase.php:590	XHP16	TODO Comment
Advice	src/parser/calendar/data/__tests__/PhutilCalendarRecurrenceRuleTestCase.php:650	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 13878
Build 17964: Run Core Tests
Build 17963: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39989.Sep 28 2016, 1:24 AM

epriestley retitled this revision from to Add many working RRULE test cases.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 28 2016, 1:36 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 28 2016, 1:36 AM

Closed by commit rPHU16cb15ae0c22: Add many working RRULE test cases (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 12:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

215 lines

Diff 39989

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Add many working RRULE test casesClosedPublicActions