Differential D16615

Fix an RRULE bug with MONTHLY INTERVALs larger than 12
ClosedPublic
Actions

Authored by epriestley on Sep 28 2016, 1:06 AM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU50db12901a84: Fix an RRULE bug with MONTHLY INTERVALs larger than 12

Summary

Ref T10747. This was a simple typo of "-" where "-=" should be used.

Test Plan

Unit tests now pass.

Diff Detail

Repository

rPHU libphutil

Branch

cal13

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/parser/calendar/data/__tests__/PhutilCalendarRecurrenceRuleTestCase.php:422	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 13877
Build 17962: Run Core Tests
Build 17961: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39988.Sep 28 2016, 1:06 AM

epriestley retitled this revision from to Fix an RRULE bug with MONTHLY INTERVALs larger than 12.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 28 2016, 1:16 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 28 2016, 1:16 AM

Closed by commit rPHU50db12901a84: Fix an RRULE bug with MONTHLY INTERVALs larger than 12 (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 12:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

2 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

53 lines

Diff 39988

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Fix an RRULE bug with MONTHLY INTERVALs larger than 12ClosedPublicActions