Add some working RRULE unit tests
ClosedPublic
Actions

Authored by epriestley on Sep 28 2016, 12:28 AM.

Tags

None

Referenced Files

	F15475396: D16613.id40003.diff
	Sun, Apr 6, 7:36 PM

	F15475282: D16613.diff
	Sun, Apr 6, 5:57 PM

	F15456455: D16613.id39986.diff
	Sun, Mar 30, 9:50 AM

	F15396794: D16613.diff
	Sun, Mar 16, 4:20 PM

	F15389940: D16613.id.diff
	Sat, Mar 15, 5:46 AM

	F15389126: D16613.id40003.diff
	Sat, Mar 15, 4:55 AM

	F15383615: D16613.diff
	Fri, Mar 14, 5:22 PM

	F15382323: D16613.id39986.diff
	Fri, Mar 14, 11:51 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU4e9a2288f527: Add some working RRULE unit tests

Summary

Ref T10747. These tests already work and didn't uncover any bugs.

(The next one deals with BYSETPOS and I think my approach isn't correct and needs significant work to correct, unfortuantely.)

Test Plan

Unit tests pass.

Diff Detail

Repository

rPHU libphutil

Branch

cal11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13875
Build 17958: Run Core Tests
Build 17957: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39986.Sep 28 2016, 12:28 AM

epriestley retitled this revision from to Add some working RRULE unit tests.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 28 2016, 12:41 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 28 2016, 12:41 AM

Closed by commit rPHU4e9a2288f527: Add some working RRULE unit tests (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 12:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

69 lines

Diff 39986

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Add some working RRULE unit testsClosedPublicActions