Differential D16606

Fix an RRULE issue where BYMONTHDAY did not properly expand the month set
ClosedPublic
Actions

Authored by epriestley on Sep 27 2016, 10:41 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU4f0b4899b570: Fix an RRULE issue where BYMONTHDAY did not properly expand the month set

Summary

Ref T10747. When you have BYMONTHDAY, we need to expand the set of months by default, per the comment.

Test Plan

Unit test now passes.

Diff Detail

Repository

rPHU libphutil

Branch

cal4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13867
Build 17942: Run Core Tests
Build 17941: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39978.Sep 27 2016, 10:41 PM

epriestley retitled this revision from to Fix an RRULE issue where BYMONTHDAY did not properly expand the month set.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 27 2016, 10:45 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 27 2016, 10:45 PM

Closed by commit rPHU4f0b4899b570: Fix an RRULE issue where BYMONTHDAY did not properly expand the month set (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 12:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

7 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

28 lines

Diff 39978

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Fix an RRULE issue where BYMONTHDAY did not properly expand the month setClosedPublicActions