Page MenuHomePhabricator
Differential D16584

Backport fix from php-mime-mail-parser to fix attachment parsing
ClosedPublic
Actions

Authored by bzerr on Sep 21 2016, 9:51 PM.
Tags
None
Referenced Files
F15411349: D16584.diff
Wed, Mar 19, 9:07 AM
F15379606: D16584.id39917.diff
Thu, Mar 13, 10:16 PM
F15353650: D16584.diff
Mon, Mar 10, 11:28 PM
Unknown Object (File)
Feb 18 2025, 11:46 AM
Unknown Object (File)
Feb 9 2025, 2:27 AM
Unknown Object (File)
Jan 29 2025, 5:43 PM
Unknown Object (File)
Jan 29 2025, 12:27 PM
Unknown Object (File)
Jan 25 2025, 10:53 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPaf218564e51a: Backport fix from php-mime-mail-parser to fix attachment parsing
Summary
  • Allow proper parsing of attachments with missing Content-Disposition header
Test Plan
  • Create application email for Maniphest.
  • Send example broken email from Outlook 2007 to that address
    Outlook_Inline.eml38 KBDownload

Diff Detail

Repository
rP Phabricator
Branch
fix-mail-attachments
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13802
Build 17836: arc lint + arc unit

Event Timeline

bzerr updated this revision to Diff 39916.Sep 21 2016, 9:51 PM
bzerr retitled this revision from to Backport fix from php-mime-mail-parser to fix attachment parsing.
bzerr updated this object.
bzerr edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 21 2016, 9:51 PM
Herald added a subscriber: epriestley. · View Herald Transcript
bzerr mentioned this in T11678: Inline images from emails sent from Outlook are not correctly attached to Maniphest Tasks.Sep 21 2016, 9:52 PM
epriestley accepted this revision.Sep 21 2016, 10:02 PM
epriestley added a reviewer: epriestley.
epriestley added inline comments.
externals/mimemailparser/MimeMailParser.class.php
260

Missing some text in this comment ("Some mail clients do not..."), but I'll fix that locally. Thanks!

This revision is now accepted and ready to land.Sep 21 2016, 10:02 PM
Closed by commit rPaf218564e51a: Backport fix from php-mime-mail-parser to fix attachment parsing (authored by bzerr, committed by epriestley). · Explain WhySep 21 2016, 10:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
externals/
mimemailparser/
101 lines

Diff 39916

View Options

externals/mimemailparser/MimeMailParser.class.php

Loading...
Phabricator · Built by Phacility