Differential D16559

Make .ics export less scary and attach .ics files to event mail
ClosedPublic
Actions

Authored by epriestley on Sep 15 2016, 2:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 1, 1:37 PM

	Unknown Object (File)
	Wed, Dec 25, 10:05 PM

	Unknown Object (File)
	Wed, Dec 25, 10:05 PM

	Unknown Object (File)
	Wed, Dec 25, 10:05 PM

	Unknown Object (File)
	Wed, Dec 25, 5:57 PM

	Unknown Object (File)
	Tue, Dec 24, 3:51 AM

	Unknown Object (File)
	Sun, Dec 15, 11:32 PM

	Unknown Object (File)
	Sat, Dec 14, 9:00 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rP3d6c3c2c45e8: Make .ics export less scary and attach .ics files to event mail

Summary

Remove the warning dialog since these files don't seem to do anything confusing/problematic in Calendar.app or Google Calendar. Those importers generally need to be defensive about how they handle random ".ics" files from arbitrary third parties anyway, and this makes testing imports easier since we have a GET-table ".ics" URI for public events.
Attach ".ics" files to email.

Test Plan

Clicked "Export as .ics", got an ICS file.
Used "bin/mail show-outbound" to review an ICS attachment, although I don't actually have real mail set up locally so this may still be a little funky.

Diff Detail

Repository

Branch

ics9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13731
Build 17725: Run Core Tests
Build 17724: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39852.Sep 15 2016, 2:01 PM

epriestley retitled this revision from to Make .ics export less scary and attach .ics files to event mail.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 15 2016, 2:40 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 15 2016, 2:40 PM

Closed by commit rP3d6c3c2c45e8: Make .ics export less scary and attach .ics files to event mail (authored by epriestley, committed by epriestley). · Explain WhySep 15 2016, 5:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

application/

PhabricatorCalendarApplication.php

2 lines

controller/

PhabricatorCalendarEventExportController.php

38 lines

PhabricatorCalendarEventViewController.php

6 lines

editor/

PhabricatorCalendarEventEditor.php

24 lines

storage/

PhabricatorCalendarEvent.php

3 lines

Diff 39852

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventExportController.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...