Page MenuHomePhabricator
Differential D16552

Support more ICS parameters and properties
ClosedPublic
Actions

Authored by epriestley on Sep 15 2016, 12:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 2, 4:22 AM
Unknown Object (File)
Sat, Feb 1, 2:20 AM
Unknown Object (File)
Thu, Jan 30, 9:04 AM
Unknown Object (File)
Sat, Jan 25, 2:04 PM
Unknown Object (File)
Sat, Jan 25, 2:04 PM
Unknown Object (File)
Sat, Jan 25, 2:04 PM
Unknown Object (File)
Sat, Jan 25, 2:03 PM
Unknown Object (File)
Thu, Jan 23, 8:30 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rPHUb398e48a8fc7: Support more ICS parameters and properties
Summary

Ref T10747. Support property parameters, all-day events, and some other static fields.

Test Plan

Added and ran unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
ics5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13716
Build 17702: Run Core Tests
Build 17701: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39836.Sep 15 2016, 12:10 AM
epriestley retitled this revision from to Support more ICS parameters and properties.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
epriestley updated this revision to Diff 39837.Sep 15 2016, 12:16 AM
  • Also use CRLF newlines instead of LF, as mandated by RFC5545.
chad accepted this revision.Sep 15 2016, 12:44 AM
chad edited edge metadata.
chad added inline comments.
src/parser/calendar/ics/PhutilICSWriter.php
131

so fetch

This revision is now accepted and ready to land.Sep 15 2016, 12:44 AM
Closed by commit rPHUb398e48a8fc7: Support more ICS parameters and properties (authored by epriestley, committed by epriestley). · Explain WhySep 15 2016, 2:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39837

View Options

src/parser/calendar/data/PhutilCalendarAbsoluteDateTime.php

Loading...
View Options

src/parser/calendar/data/PhutilCalendarDateTime.php

Loading...
View Options

src/parser/calendar/data/PhutilCalendarProxyDateTime.php

Loading...
View Options

src/parser/calendar/ics/PhutilICSWriter.php

Loading...
View Options

src/parser/calendar/ics/__tests__/PhutilICSWriterTestCase.php

Loading...
View Options

src/parser/calendar/ics/__tests__/data/writer-christmas.ics

Loading...
View Options

src/parser/calendar/ics/__tests__/data/writer-tea-time.ics

Loading...
Phabricator · Built by Phacility