Paths

Table of Contentst

Differential D16551

Write basic ICS files from Phutil intermediate objects
ClosedPublic
Actions

Authored by epriestley on Sep 14 2016, 8:50 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU7c1fc80a54f0: Write basic ICS files from Phutil intermediate objects

Summary

Ref T10747. Allows the intermediate event representation to be written out to an ICS file. This isn't full-featured but the core works.

Test Plan

Added unit tests, ran unit tests.

Imported the resulting .ics file into Calendar.app, got an equivalent event:

Screen Shot 2016-09-14 at 1.44.23 PM.png (324×472 px, 59 KB)

Diff Detail

Repository

rPHU libphutil

Branch

ics4

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/parser/calendar/ics/PhutilICSWriter.php:219	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 13714
Build 17698: Run Core Tests
Build 17697: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39835.Sep 14 2016, 8:50 PM

epriestley retitled this revision from to Write basic ICS files from Phutil intermediate objects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

If you wanted this to closely follow the specification (RFC 5545), then you need to add VERSION and PRODID, ex:

VERSION:2.0
PRODID:-//phabricator/calexport//NONSGML v1.0//EN

chad accepted this revision.Sep 15 2016, 12:42 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 15 2016, 12:42 AM

Closed by commit rPHU7c1fc80a54f0: Write basic ICS files from Phutil intermediate objects (authored by epriestley, committed by epriestley). · Explain WhySep 15 2016, 2:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

parser/

calendar/

data/

PhutilCalendarAbsoluteDateTime.php

46 lines

PhutilCalendarDateTime.php

6 lines

PhutilCalendarEventNode.php

37 lines

ics/

PhutilICSParser.php

60 lines

PhutilICSWriter.php

228 lines

__tests__/

PhutilICSWriterTestCase.php

61 lines

data/

writer-tea-time.ics

14 lines

Diff 39835

View Options

src/__phutil_library_map__.php

View Options

src/parser/calendar/data/PhutilCalendarAbsoluteDateTime.php

View Options

src/parser/calendar/data/PhutilCalendarDateTime.php

View Options

src/parser/calendar/data/PhutilCalendarEventNode.php

View Options

src/parser/calendar/ics/PhutilICSParser.php

View Options

src/parser/calendar/ics/PhutilICSWriter.php

View Options

src/parser/calendar/ics/tests/PhutilICSWriterTestCase.php

View Options

src/parser/calendar/ics/tests/data/writer-tea-time.ics

Write basic ICS files from Phutil intermediate objectsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39835

src/__phutil_library_map__.php

src/parser/calendar/data/PhutilCalendarAbsoluteDateTime.php

src/parser/calendar/data/PhutilCalendarDateTime.php

src/parser/calendar/data/PhutilCalendarEventNode.php

src/parser/calendar/ics/PhutilICSParser.php

src/parser/calendar/ics/PhutilICSWriter.php

src/parser/calendar/ics/__tests__/PhutilICSWriterTestCase.php

src/parser/calendar/ics/__tests__/data/writer-tea-time.ics

Write basic ICS files from Phutil intermediate objects
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/calendar/ics/tests/PhutilICSWriterTestCase.php

src/parser/calendar/ics/tests/data/writer-tea-time.ics