Page MenuHomePhabricator
Differential D16537

Fixed inconsistency at phriction
ClosedPublic
Actions

Authored by Luke081515.2 on Sep 10 2016, 10:15 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Dec 20, 10:02 PM
Unknown Object (File)
Thu, Dec 5, 3:58 PM
Unknown Object (File)
Thu, Nov 28, 9:29 AM
Unknown Object (File)
Thu, Nov 28, 9:29 AM
Unknown Object (File)
Thu, Nov 28, 8:49 AM
Unknown Object (File)
Nov 5 2024, 11:33 PM
Unknown Object (File)
Nov 5 2024, 11:32 PM
Unknown Object (File)
Nov 5 2024, 11:32 PM
View All Files
Subscribers
avivey
chad
epriestley

Details

Reviewers
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T11614: Inconsistency at phriction
Commits
rP9e4bca834510: Fixed inconsistency at phriction
Summary
  • All Applications are useing the description "Tags", Phriction actually uses "Projects"
  • Changed "Projects" to "Tags" for phriction

Ref T11614

Test Plan
  • Edited a document, took a look at the description for that input line
  • Added a project to a page and saved it

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/applications/auth/provider/PhabricatorSlackAuthProvider.php:29PHL1Unknown Symbol
Unit
Tests Passed
Build Status
Buildable 13675
Build 17635: arc lint + arc unit

Event Timeline

Luke081515.2 updated this revision to Diff 39793.Sep 10 2016, 10:15 PM
Luke081515.2 retitled this revision from to Fixed inconsistency at phriction.
Luke081515.2 updated this object.
Luke081515.2 edited the test plan for this revision. (Show Details)
Luke081515.2 added a project: Phriction.
Luke081515.2 added a task: T11614: Inconsistency at phriction.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 10 2016, 10:15 PM
Herald added a subscriber: epriestley. · View Herald Transcript
chad added a subscriber: chad.Sep 10 2016, 10:42 PM

This works?

avivey added a subscriber: avivey.Sep 11 2016, 12:08 AM

Did you try to actually set a project tag with this change? I'm pretty sure it wouldn't work.

chad requested changes to this revision.Sep 11 2016, 12:36 AM
chad added a reviewer: chad.

This shouldn't work, since your changing the variable name as well below, but not above to write the changes. I'd expect this to not record the tag.

This revision now requires changes to proceed.Sep 11 2016, 12:36 AM
Luke081515.2 added a comment.EditedSep 11 2016, 12:39 AM

At least it did what I wanted, and it worked without an error:
Before:

before.PNG (551×288 px, 9 KB)

After:
after.PNG (492×236 px, 6 KB)

chad added a comment.Sep 11 2016, 12:53 AM

Did you click "Submit" and verify the tag you specified was on the document?

Luke081515.2 added a comment.Sep 11 2016, 1:01 AM

hm, ok, that was the reason. I don't checked that, sorry. Feel free to comandeer that rev, and upload a better patch.

chad added inline comments.Sep 11 2016, 1:10 AM
src/applications/phriction/controller/PhrictionEditController.php
251

just change setName back to projects and it should work again. this field isn't visible to users.

Luke081515.2 updated this revision to Diff 39797.Sep 11 2016, 1:04 PM
Luke081515.2 edited edge metadata.
  • Fixed issue pointed out by @chad
Luke081515.2 edited the test plan for this revision. (Show Details)Sep 11 2016, 1:06 PM
Luke081515.2 edited edge metadata.
Luke081515.2 marked an inline comment as done.
chad accepted this revision.Sep 11 2016, 6:06 PM
chad edited edge metadata.

thanks!

This revision is now accepted and ready to land.Sep 11 2016, 6:06 PM
Luke081515.2 added a comment.Sep 11 2016, 7:35 PM

@chad Can you land this revision yourself, or give me the permissions to do so? I'm currently not able too :-/

Closed by commit rP9e4bca834510: Fixed inconsistency at phriction (authored by Luke081515.2, committed by chad). · Explain WhySep 11 2016, 8:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
applications/
phriction/
controller/
4 lines0%
Loading...

Diff 39793

View Options

src/applications/phriction/controller/PhrictionEditController.php

Loading...
Phabricator · Built by Phacility