Page MenuHomePhabricator
Differential D16530

Lots of favicons
ClosedPublic
Actions

Authored by chad on Sep 9 2016, 4:37 PM.
Tags
None
Referenced Files
F14344942: D16530.id.diff
Thu, Dec 19, 12:54 AM
Unknown Object (File)
Mon, Dec 9, 12:15 PM
Unknown Object (File)
Thu, Dec 5, 2:03 AM
Unknown Object (File)
Tue, Dec 3, 11:02 PM
Unknown Object (File)
Thu, Nov 28, 7:05 AM
Unknown Object (File)
Thu, Nov 28, 7:05 AM
Unknown Object (File)
Thu, Nov 28, 7:04 AM
Unknown Object (File)
Thu, Nov 28, 6:45 AM
View All Files
Subscribers
avivey
Korvin

Details

Reviewers
epriestley
Commits
rP05f5653091ee: Lots of favicons
Summary

Swaps to new logo, new color for default favicon. Adds red, yellow, dark for other uses. perhaps.

Test Plan

reload, see new favicon

Diff Detail

Repository
rP Phabricator
Branch
favicon (branched from master)
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/favicons/mask-icon.svg:5TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 13661
Build 17611: Run Core Tests
Build 17610: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39778.Sep 9 2016, 4:37 PM
chad retitled this revision from to Lots of favicons.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 9 2016, 4:37 PM
epriestley accepted this revision.Sep 9 2016, 6:28 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 9 2016, 6:28 PM
Closed by commit rP05f5653091ee: Lots of favicons (authored by chad, committed by chad). · Explain WhySep 9 2016, 6:29 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Sep 9 2016, 6:31 PM

Slight concern that a gear might be confusing, but will see in practice. No idea how to wire up any of these for realtime.

avivey added a subscriber: avivey.EditedSep 9 2016, 7:03 PM

pasted_file (60×249 px, 6 KB)

That's Chrome's setting panel...

Revision Contents
Changeset List

Diff 39778

View Options

resources/celerity/map.php

Loading...
View Options

webroot/favicon.ico

Loading...
View Options

webroot/rsrc/favicons/apple-touch-icon-120x120.png

Loading...
View Options

webroot/rsrc/favicons/apple-touch-icon-152x152.png

Loading...
View Options

webroot/rsrc/favicons/apple-touch-icon-60x60.png

Loading...
View Options

webroot/rsrc/favicons/apple-touch-icon-76x76.png

Loading...
View Options

webroot/rsrc/favicons/dark/apple-touch-icon-120x120.png

Loading...
View Options

webroot/rsrc/favicons/dark/apple-touch-icon-152x152.png

Loading...
View Options

webroot/rsrc/favicons/dark/apple-touch-icon-76x76.png

Loading...
View Options

webroot/rsrc/favicons/dark/favicon-128.png

Loading...
View Options

webroot/rsrc/favicons/dark/favicon-16x16.png

Loading...
View Options

webroot/rsrc/favicons/dark/favicon-196x196.png

Loading...
View Options

webroot/rsrc/favicons/dark/favicon-32x32.png

Loading...
View Options

webroot/rsrc/favicons/dark/favicon-96x96.png

Loading...
View Options

webroot/rsrc/favicons/favicon-128.png

Loading...
View Options

webroot/rsrc/favicons/favicon-16x16.png

Loading...
View Options

webroot/rsrc/favicons/favicon-196x196.png

Loading...
View Options

webroot/rsrc/favicons/favicon-32x32.png

Loading...
View Options

webroot/rsrc/favicons/favicon-96x96.png

Loading...
View Options

webroot/rsrc/favicons/favicon.ico

Loading...
View Options

webroot/rsrc/favicons/mask-icon.svg

Loading...
View Options

webroot/rsrc/favicons/red/apple-touch-icon-120x120.png

Loading...
View Options

webroot/rsrc/favicons/red/apple-touch-icon-152x152.png

Loading...
View Options

webroot/rsrc/favicons/red/apple-touch-icon-76x76.png

Loading...
View Options

webroot/rsrc/favicons/red/favicon-128.png

Loading...
View Options

webroot/rsrc/favicons/red/favicon-16x16.png

Loading...
View Options

webroot/rsrc/favicons/red/favicon-196x196.png

Loading...
View Options

webroot/rsrc/favicons/red/favicon-32x32.png

Loading...
View Options

webroot/rsrc/favicons/red/favicon-96x96.png

Loading...
View Options

webroot/rsrc/favicons/red/favicon.ico

Loading...
View Options

webroot/rsrc/favicons/yellow/apple-touch-icon-120x120.png

Loading...
View Options

webroot/rsrc/favicons/yellow/apple-touch-icon-152x152.png

Loading...
View Options

webroot/rsrc/favicons/yellow/apple-touch-icon-76x76.png

Loading...
View Options

webroot/rsrc/favicons/yellow/favicon-128.png

Loading...
View Options

webroot/rsrc/favicons/yellow/favicon-16x16.png

Loading...
View Options

webroot/rsrc/favicons/yellow/favicon-196x196.png

Loading...
View Options

webroot/rsrc/favicons/yellow/favicon-32x32.png

Loading...
View Options

webroot/rsrc/favicons/yellow/favicon-96x96.png

Loading...
View Options

webroot/rsrc/favicons/yellow/favicon.ico

Loading...
Phabricator · Built by Phacility