Page MenuHomePhabricator

Add inline styles for `{key ...}` in HTML mail
ClosedPublic

Authored by epriestley on Sep 8 2016, 11:39 PM.
Tags
None
Referenced Files
F13226727: D16523.id.diff
Sun, May 19, 10:54 PM
F13222614: D16523.diff
Sun, May 19, 3:49 AM
F13217676: D16523.id39762.diff
Sat, May 18, 7:01 AM
F13202955: D16523.diff
Tue, May 14, 11:21 PM
Unknown Object (File)
Sat, May 4, 6:57 PM
Unknown Object (File)
Wed, May 1, 12:26 AM
Unknown Object (File)
Apr 7 2024, 4:41 AM
Unknown Object (File)
Mar 10 2024, 2:26 AM
Subscribers
None

Details

Summary

Fixes T11607.

Test Plan
  • Made a comment using {key ...}.
  • Used bin/mail show-outbound --id X --dump-html > test.html to review HTML:

Screen Shot 2016-09-08 at 4.38.06 PM.png (1×1 px, 109 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add inline styles for `{key ...}` in HTML mail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 9 2016, 12:08 AM

some day we will be able to write all our CSS in PHP so we don't have to do this :3

This revision was automatically updated to reflect the committed changes.