Page MenuHomePhabricator
Differential D16516

Always show a menu on durable column
ClosedPublic
Actions

Authored by chad on Sep 7 2016, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 5:45 AM
Unknown Object (File)
Mon, Jan 27, 11:57 PM
Unknown Object (File)
Mon, Jan 27, 11:13 AM
Unknown Object (File)
Mon, Jan 27, 3:50 AM
Unknown Object (File)
Mon, Jan 27, 12:40 AM
Unknown Object (File)
Tue, Jan 21, 9:16 AM
Unknown Object (File)
Sat, Jan 18, 5:25 AM
Unknown Object (File)
Wed, Jan 8, 7:30 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9195: Durable column menu should always display
Commits
rP5a33a6743e92: Always show a menu on durable column
Summary

If you don't have any rooms, we currently show no menu and users have no logical means of closing the column. This lets "Hide Column" at least still appear. Fixes T9195

Test Plan

Diff Detail

Repository
rP Phabricator
Branch
conph (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13626
Build 17560: Run Core Tests
Build 17559: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39747.Sep 7 2016, 9:26 PM
chad retitled this revision from to Always show a menu on durable column.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9195: Durable column menu should always display.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 7 2016, 9:26 PM
epriestley accepted this revision.Sep 7 2016, 9:26 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 7 2016, 9:26 PM
Closed by commit rP5a33a6743e92: Always show a menu on durable column (authored by chad, committed by chad). · Explain WhySep 7 2016, 9:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
conpherence/
view/
168 lines
webroot/
rsrc/
css/
application/
base/
1 line

Diff 39747

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
Phabricator · Built by Phacility