Properly set project icon in timeline
ClosedPublic
Actions

Authored by chad on Sep 7 2016, 5:35 PM.

Details

Reviewers

epriestley

Commits

rP7368859d8df0: Properly set project icon in timeline

Summary

This fixes a bug where the icon won't display since it doesn't include fa-.

Test Plan

Change icon on a project, revisit timeline and see icon.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39739.Sep 7 2016, 5:35 PM

chad retitled this revision from to Properly set project icon in timeline.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 7 2016, 5:35 PM

epriestley accepted this revision.Sep 7 2016, 5:36 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 7 2016, 5:36 PM

Actually, I think this is maybe still wrong? I think $new is just a key which happens to be the right value most of the time.

Actual code is this, I believe:

$set = new PhabricatorProjectIconSet();
$font_icon = $set->getIconIcon($new);

Closed by commit rP7368859d8df0: Properly set project icon in timeline (authored by chad, committed by chad). · Explain WhySep 7 2016, 5:37 PM

This revision was automatically updated to reflect the committed changes.

(If you set it to the "lock" icon I think this will try to render fa-policy, which is incorrect/invalid/does not exist.)

ah, I only tested group. I guess I got lucky.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

storage/

PhabricatorProjectTransaction.php

2 lines

Diff 39740

View Options

src/applications/project/storage/PhabricatorProjectTransaction.php

Properly set project icon in timelineClosedPublicActions