This fixes a bug where the icon won't display since it doesn't include fa-.
Details
Details
- Reviewers
epriestley - Commits
- rP7368859d8df0: Properly set project icon in timeline
Change icon on a project, revisit timeline and see icon.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- proj-icon (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 13618 Build 17548: Run Core Tests Build 17547: arc lint + arc unit
Event Timeline
Comment Actions
Actually, I think this is maybe still wrong? I think $new is just a key which happens to be the right value most of the time.
Actual code is this, I believe:
$set = new PhabricatorProjectIconSet(); $font_icon = $set->getIconIcon($new);
Comment Actions
(If you set it to the "lock" icon I think this will try to render fa-policy, which is incorrect/invalid/does not exist.)