Paths

Table of Contentst

Differential D16489

Distinguish between unreachable cluster database hosts and missing MySQL databases
ClosedPublic
Actions

Authored by epriestley on Sep 2 2016, 3:08 PM.

Tags

None

Referenced Files

	F14033848: D16489.id39672.diff
	Sat, Nov 9, 8:25 PM

	F13983498: D16489.diff
	Sun, Oct 20, 6:48 AM

	F13961542: D16489.id.diff
	Oct 15 2024, 5:27 AM

	Unknown Object (File)
	Sep 20 2024, 1:00 PM

	Unknown Object (File)
	Sep 18 2024, 11:10 PM

	Unknown Object (File)
	Sep 12 2024, 8:41 AM

	Unknown Object (File)
	Sep 11 2024, 10:52 PM

	Unknown Object (File)
	Sep 5 2024, 9:36 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11577: Initializing databases for the first time while already in cluster mode fails

Commits

rPd0013d08983a: Distinguish between unreachable cluster database hosts and missing MySQL…

Summary

Fixes T11577. When we connect to a host and try to select a database which does not exist, we currently treat it as though the host wasn't reachable.

This isn't correct, and prevents storage from being initialized while already in cluster mode, since the "config" database won't exist yet the first time we connect.

Instead, distinguish between AphrontSchemaQueryException (thrown on connection if the requested database is not present) and other errors.

Test Plan

Put Phabricator into cluster database mode (cluster.databases = ...).
Swapped storage.default-namespace to force initialization of a new install.
Ran bin/storage upgrade.
- Before patch: Immediate fatal about unreachablility.
- After patch: Database initialized.
Also ran initialization steps in tranditional single-host mode (cluster.databases empty, mysql.host configured).

Diff Detail

Repository

Branch

clusterinit

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13547
Build 17441: Run Core Tests
Build 17440: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39672.Sep 2 2016, 3:08 PM

epriestley retitled this revision from to Distinguish between unreachable cluster database hosts and missing MySQL databases.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11577: Initializing databases for the first time while already in cluster mode fails.

chad accepted this revision.Sep 2 2016, 3:11 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 2 2016, 3:11 PM

epriestley edited the test plan for this revision. (Show Details)Sep 2 2016, 3:12 PM

epriestley edited edge metadata.

Closed by commit rPd0013d08983a: Distinguish between unreachable cluster database hosts and missing MySQL… (authored by epriestley, committed by epriestley). · Explain WhySep 2 2016, 3:23 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11579: DB column missing default value or should be nullable....Sep 2 2016, 8:27 PM

epriestley mentioned this in T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.Sep 5 2016, 3:02 PM

epriestley mentioned this in D16501: Raise setup warnings immediately when failing to load configuration from the database.Sep 6 2016, 7:59 PM

epriestley mentioned this in rP00bb0c907147: Raise setup warnings immediately when failing to load configuration from the….Sep 6 2016, 9:20 PM

epriestley mentioned this in rPa1338bd2d889: (stable) Raise setup warnings immediately when failing to load configuration….Sep 8 2016, 2:25 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

cluster/

PhabricatorDatabaseRef.php

6 lines

env/

PhabricatorEnv.php

2 lines

Diff 39672

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Loading...

src/infrastructure/env/PhabricatorEnv.php

Loading...