Page MenuHomePhabricator

Use phutil_json_encode() in AphrontResponse to raise better errors
ClosedPublic

Authored by epriestley on Aug 26 2016, 12:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 5, 7:01 AM
Unknown Object (File)
Wed, Feb 5, 3:15 AM
Unknown Object (File)
Wed, Feb 5, 3:15 AM
Unknown Object (File)
Sat, Feb 1, 2:09 AM
Unknown Object (File)
Sun, Jan 26, 7:01 AM
Unknown Object (File)
Fri, Jan 24, 3:46 PM
Unknown Object (File)
Fri, Jan 24, 3:46 PM
Unknown Object (File)
Fri, Jan 24, 3:46 PM
Subscribers
None

Details

Summary

Ref T11524. This problem was more difficult to diagnose than necessary because we swallow errors silently in AphontResponse when emitting JSON responses.

Instead of using json_encode(), use phutil_json_encode() which throws on failure.

Test Plan

Old behavior was HTTP 200 with no body.

New behavior is HTTP 500 with this message:

[2016-08-26 07:33:59] EXCEPTION: (HTTPFutureHTTPResponseStatus) [HTTP/500] Internal Server Error
Exception: Failed to JSON encode value (#5: Malformed UTF-8 characters, possibly incorrectly encoded): Dictionary value at key "result" is not valid UTF8, and cannot be JSON encoded: diff --git a/latin1.txt b/latin1.txt
new file mode 100644
index 0000000..ce6c927
--- /dev/null
+++ b/latin1.txt
@@ -0,0 +1 @@
+<�>
. at [<phutil>/src/future/http/BaseHTTPFuture.php:339]

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use phutil_json_encode() in AphrontResponse to raise better errors.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
This revision is now accepted and ready to land.Aug 26 2016, 1:37 PM
This revision was automatically updated to reflect the committed changes.