Page MenuHomePhabricator

Make the chatbot obey the object name blacklist
ClosedPublic

Authored by jcox on Aug 24 2016, 7:47 PM.
Tags
None
Referenced Files
F19804580: D16442.id.diff
Mon, Mar 2, 8:36 AM
F19804579: D16442.id.diff
Mon, Mar 2, 8:36 AM
F19775283: D16442.id39547.diff
Feb 21 2026, 9:41 PM
F19673137: D16442.id39546.diff
Feb 8 2026, 4:52 AM
F19515910: D16442.diff
Jan 14 2026, 5:28 PM
F19515909: D16442.diff
Jan 14 2026, 5:28 PM
F19174164: D16442.diff
Dec 15 2025, 10:45 PM
F19152095: D16442.diff
Dec 11 2025, 12:37 AM
Subscribers

Details

Summary

Fixes T11508. The config entry remarkup.ignored-object-names already contains a blacklist of object names that should be ignored in the web UI. This change makes that blacklist also apply to the chatbot. This makes it possible to have a chatbot ignore things like V1, V2, Q1 and any other phrases the user may not want to generate links to objects.

Test Plan

Create objects (tasks, slowvotes, etc.) then mention the object names in chat (with the bot running). The bot should respond with helpful links to the given objects. Then add the object names to the blacklist through the config web UI. This apparently triggers the bot to restart itself. Then mention the object names in chat again. The bot should no longer respond with links because those object names have been added to the blacklist regex.

Diff Detail

Repository
rP Phabricator
Branch
ChatBotBlacklist (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13422
Build 17240: Run Core Tests
Build 17239: arc lint + arc unit

Event Timeline

jcox retitled this revision from to Make the chatbot obey the object name blacklist.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Aug 24 2016, 7:49 PM
This revision was automatically updated to reflect the committed changes.