Page MenuHomePhabricator

Provide a new "hint" table for weird commits (rewritten, unreadable)
ClosedPublic

Authored by epriestley on Aug 24 2016, 12:06 PM.
Tags
None
Referenced Files
F13256370: D16434.diff
Sat, May 25, 11:27 AM
F13241023: D16434.id.diff
Wed, May 22, 6:39 PM
F13230836: D16434.diff
Mon, May 20, 11:21 PM
F13225344: D16434.id39525.diff
Sun, May 19, 2:42 PM
F13213179: D16434.diff
Fri, May 17, 7:29 AM
F13209843: D16434.id39540.diff
Fri, May 17, 2:28 AM
F13207851: D16434.id39525.diff
Thu, May 16, 4:57 AM
F13207763: D16434.id39525.diff
Thu, May 16, 3:56 AM
Subscribers
None

Details

Summary

Ref T11522. This provides storage for tracking rewritten commits (new feature) and unreadable commits (existing feature, but really hacky).

This doesn't do anything yet, just adds a table and a CLI tool for updating it. I'll document the tool once it works. You just pipe in some JSON, but I need to document the format.

Test Plan
  • Piped JSON for "none", "rewritten" and "unreadable" hints into bin/repository hint.
  • Examined the database to see that the table was written properly.
  • Tried to pipe bad JSON in, invalid hint types, etc. Got reasonable human-readable error messages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide a new "hint" table for weird commits (rewritten, unreadable).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 3:53 PM
This revision was automatically updated to reflect the committed changes.