Page MenuHomePhabricator

Provide a new "hint" table for weird commits (rewritten, unreadable)
ClosedPublic

Authored by epriestley on Aug 24 2016, 12:06 PM.
Tags
None
Referenced Files
F21338439: D16434.id39540.diff
Fri, Jul 10, 5:07 PM
Unknown Object (File)
May 28 2026, 12:39 PM
Unknown Object (File)
Apr 11 2026, 3:48 AM
Unknown Object (File)
Apr 10 2026, 1:20 AM
Unknown Object (File)
Mar 30 2026, 1:14 AM
Unknown Object (File)
Mar 29 2026, 9:33 AM
Unknown Object (File)
Mar 4 2026, 4:15 PM
Unknown Object (File)
Feb 10 2026, 8:24 PM
Subscribers
None

Details

Summary

Ref T11522. This provides storage for tracking rewritten commits (new feature) and unreadable commits (existing feature, but really hacky).

This doesn't do anything yet, just adds a table and a CLI tool for updating it. I'll document the tool once it works. You just pipe in some JSON, but I need to document the format.

Test Plan
  • Piped JSON for "none", "rewritten" and "unreadable" hints into bin/repository hint.
  • Examined the database to see that the table was written properly.
  • Tried to pipe bad JSON in, invalid hint types, etc. Got reasonable human-readable error messages.

Diff Detail

Repository
rP Phabricator
Branch
hint1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13401
Build 17207: Run Core Tests
Build 17206: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Provide a new "hint" table for weird commits (rewritten, unreadable).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 3:53 PM
This revision was automatically updated to reflect the committed changes.