Page MenuHomePhabricator

Provide a new "hint" table for weird commits (rewritten, unreadable)
ClosedPublic

Authored by epriestley on Aug 24 2016, 12:06 PM.
Tags
None
Referenced Files
F14053250: D16434.diff
Fri, Nov 15, 1:46 PM
F14047417: D16434.diff
Thu, Nov 14, 3:50 AM
F14043689: D16434.diff
Tue, Nov 12, 12:13 PM
F14039094: D16434.diff
Mon, Nov 11, 3:44 AM
F14022809: D16434.diff
Wed, Nov 6, 7:57 PM
F14006326: D16434.diff
Mon, Oct 28, 6:29 AM
Unknown Object (File)
Oct 2 2024, 1:07 AM
Unknown Object (File)
Sep 30 2024, 2:57 PM
Subscribers
None

Details

Summary

Ref T11522. This provides storage for tracking rewritten commits (new feature) and unreadable commits (existing feature, but really hacky).

This doesn't do anything yet, just adds a table and a CLI tool for updating it. I'll document the tool once it works. You just pipe in some JSON, but I need to document the format.

Test Plan
  • Piped JSON for "none", "rewritten" and "unreadable" hints into bin/repository hint.
  • Examined the database to see that the table was written properly.
  • Tried to pipe bad JSON in, invalid hint types, etc. Got reasonable human-readable error messages.

Diff Detail

Repository
rP Phabricator
Branch
hint1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13401
Build 17207: Run Core Tests
Build 17206: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Provide a new "hint" table for weird commits (rewritten, unreadable).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 3:53 PM
This revision was automatically updated to reflect the committed changes.