Page MenuHomePhabricator

Add setBackground to PHUIIconView
ClosedPublic

Authored by chad on Aug 19 2016, 7:49 PM.
Tags
None
Referenced Files
F18433275: D16424.diff
Sun, Aug 31, 7:43 AM
F18053998: D16424.diff
Mon, Aug 4, 5:55 AM
F17946471: D16424.id39496.diff
Jul 31 2025, 2:35 PM
F17930480: D16424.id39495.diff
Jul 30 2025, 6:03 PM
F17924916: D16424.id.diff
Jul 30 2025, 10:43 AM
F17902755: D16424.diff
Jul 29 2025, 10:24 AM
F17879570: D16424.id.diff
Jul 28 2025, 8:54 PM
Unknown Object (File)
May 27 2025, 11:25 AM
Subscribers

Details

Summary

Ref T11132. Adds a background color option to PHUIIconView, for use whereever, and NUX. Also normalize icon placement for mixed image/icon result list.

Test Plan

Test in UIExamples, and Global Settings.

Diff Detail

Repository
rP Phabricator
Branch
bg-icon (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13370
Build 17158: Run Core Tests
Build 17157: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add setBackground to PHUIIconView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

its bluetiful :3

This revision is now accepted and ready to land.Aug 19 2016, 8:17 PM
This revision was automatically updated to reflect the committed changes.