Page MenuHomePhabricator

Add setBackground to PHUIIconView
ClosedPublic

Authored by chad on Aug 19 2016, 7:49 PM.
Tags
None
Referenced Files
F19525314: D16424.diff
Sun, Jan 18, 7:58 AM
F19437806: D16424.diff
Dec 28 2025, 4:11 PM
F19104488: D16424.id39496.diff
Dec 5 2025, 2:21 PM
F19103469: D16424.id.diff
Dec 5 2025, 10:16 AM
F19096049: D16424.diff
Dec 4 2025, 7:52 AM
F19095826: D16424.diff
Dec 4 2025, 6:23 AM
F18872071: D16424.id39496.diff
Nov 5 2025, 2:10 AM
F18871606: D16424.id39496.diff
Nov 4 2025, 11:39 PM
Subscribers

Details

Summary

Ref T11132. Adds a background color option to PHUIIconView, for use whereever, and NUX. Also normalize icon placement for mixed image/icon result list.

Test Plan

Test in UIExamples, and Global Settings.

Diff Detail

Repository
rP Phabricator
Branch
bg-icon (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13370
Build 17158: Run Core Tests
Build 17157: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add setBackground to PHUIIconView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

its bluetiful :3

This revision is now accepted and ready to land.Aug 19 2016, 8:17 PM
This revision was automatically updated to reflect the committed changes.