Page MenuHomePhabricator

Add setBackground to PHUIIconView
ClosedPublic

Authored by chad on Aug 19 2016, 7:49 PM.
Tags
None
Referenced Files
F18835496: D16424.diff
Sun, Oct 26, 4:21 PM
F18809975: D16424.id39496.diff
Sun, Oct 19, 6:29 PM
F18781095: D16424.id39495.diff
Sun, Oct 12, 9:27 PM
F18759402: D16424.diff
Mon, Oct 6, 3:38 AM
F18756546: D16424.id39496.diff
Sun, Oct 5, 12:01 PM
F18651880: D16424.id39495.diff
Sep 21 2025, 5:51 AM
F18628738: D16424.id39496.diff
Sep 16 2025, 7:11 AM
F18509546: D16424.id39496.diff
Sep 5 2025, 3:27 AM
Subscribers

Details

Summary

Ref T11132. Adds a background color option to PHUIIconView, for use whereever, and NUX. Also normalize icon placement for mixed image/icon result list.

Test Plan

Test in UIExamples, and Global Settings.

Diff Detail

Repository
rP Phabricator
Branch
bg-icon (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13370
Build 17158: Run Core Tests
Build 17157: arc lint + arc unit

Event Timeline

chad retitled this revision from to Add setBackground to PHUIIconView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

its bluetiful :3

This revision is now accepted and ready to land.Aug 19 2016, 8:17 PM
This revision was automatically updated to reflect the committed changes.