Differential D16415

Avoid double [y/N] when updating a not owned revision
ClosedPublic
Actions

Authored by Luke081515.2 on Aug 17 2016, 4:55 PM.

Tags

Referenced Files

	F13052049: D16415.diff
	Fri, Apr 19, 6:38 AM

	Unknown Object (File)
	Sun, Apr 14, 4:59 PM

	Unknown Object (File)
	Tue, Apr 2, 10:00 PM

	Unknown Object (File)
	Mon, Apr 1, 4:22 PM

	Unknown Object (File)
	Fri, Mar 29, 2:47 PM

	Unknown Object (File)
	Mar 19 2024, 4:12 AM

	Unknown Object (File)
	Mar 16 2024, 8:50 AM

	Unknown Object (File)
	Mar 1 2024, 1:37 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T11489: Arcanist: Duplicate at question

Commits

rARC3ae0cc8d41e2: Avoid double [y/N] when updating a not owned revision

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Since 737f5c0df976fe2b3178aac6ab7feb3d3621d99e arcanist shows [y/N] two times, when arcanist asks you, if you want to proceed, if you want to update a not owned revision. Ths patch fixes
that, so that Arcanist shows [y/N] only once, like at other situations, when Arcanist asks you a question.
Ref T11489

Test Plan

Updated a not owned revision.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13350
Build 17127: arc lint + arc unit

Event Timeline

Luke081515.2 updated this revision to Diff 39474.Aug 17 2016, 4:55 PM

Luke081515.2 retitled this revision from to Avoid double [y/N] when updating a not owned revision.

Luke081515.2 updated this object.

Luke081515.2 edited the test plan for this revision. (Show Details)

Luke081515.2 added a project: Arcanist.

Luke081515.2 added a task: T11489: Arcanist: Duplicate at question.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 17 2016, 4:55 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

I hope this is ok, since this is my first patch actually...

Thanks!

This revision is now accepted and ready to land.Aug 17 2016, 5:36 PM

Closed by commit rARC3ae0cc8d41e2: Avoid double [y/N] when updating a not owned revision (authored by • Luke081515, committed by epriestley). · Explain WhyAug 17 2016, 5:36 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11489: Arcanist: Duplicate at question.Aug 17 2016, 5:36 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

workflow/

ArcanistDiffWorkflow.php

2 lines

0%

Loading...

Diff 39474

src/workflow/ArcanistDiffWorkflow.php

Loading...