Fix bad array index test in Differential package code
ClosedPublic
Actions

Authored by epriestley on Aug 14 2016, 8:08 PM.

Details

Reviewers

chad

Commits

rP15021a0bcc91: Fix bad array index test in Differential package code

Summary

This needs an isset() for cases when authority and packages don't completely overlap.

Test Plan

With a package set to trigger autoreview, created a revision.
Observed error log, saw no more error.
Saw package trigger autoreview properly.

Diff Detail

Repository

rP Phabricator

Branch

package1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13315
Build 17076: Run Core Tests
Build 17075: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39434.Aug 14 2016, 8:08 PM

epriestley retitled this revision from to Fix bad array index test in Differential package code.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Aug 14 2016, 8:10 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 14 2016, 8:10 PM

Closed by commit rP15021a0bcc91: Fix bad array index test in Differential package code (authored by epriestley, committed by epriestley). · Explain WhyAug 14 2016, 8:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

2 lines

Diff 39434

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Fix bad array index test in Differential package codeClosedPublicActions