Fix a bad DiffusionCommandEngine parameter from HTTPEngine conversion
ClosedPublic
Actions

Authored by epriestley on Aug 11 2016, 10:18 PM.

Details

Reviewers

chad

Commits

rP39d4e21eec56: Fix a bad DiffusionCommandEngine parameter from HTTPEngine conversion

Summary

I converted this call incorrectly in D16092. We should pass the PhutilURI object, not the string version of it.

Specifically, this resulted in hitting an error like this if a replica needed synchronization:

[2016-08-11 21:22:37] EXCEPTION: (InvalidArgumentException) Argument 1 passed to DiffusionCommandEngine::setURI() must be an instance of PhutilURI, string given, called in...
#0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/diffusion/protocol/DiffusionCommandEngine.php:52]
#1 DiffusionCommandEngine::setURI(string) called at [<phabricator>/src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php:601]
...

Test Plan

Clusterized an observed repository, demoted a node, ran bin/repository update Rxxx to update, saw no typehint fatal.

Diff Detail

Repository

rP Phabricator

Branch

uri1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13294
Build 17047: Run Core Tests
Build 17046: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39417.Aug 11 2016, 10:18 PM

epriestley retitled this revision from to Fix a bad DiffusionCommandEngine parameter from HTTPEngine conversion.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Aug 11 2016, 11:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 11 2016, 11:38 PM

Closed by commit rP39d4e21eec56: Fix a bad DiffusionCommandEngine parameter from HTTPEngine conversion (authored by epriestley, committed by epriestley). · Explain WhyAug 11 2016, 11:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

protocol/

DiffusionRepositoryClusterEngine.php

2 lines

Diff 39417

View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

Fix a bad DiffusionCommandEngine parameter from HTTPEngine conversionClosedPublicActions