Page MenuHomePhabricator

Add basic Herald support to Calendar
ClosedPublic

Authored by epriestley on Aug 3 2016, 11:46 PM.
Tags
None
Referenced Files
F15387396: D16368.diff
Sat, Mar 15, 2:19 AM
F15383198: D16368.id.diff
Fri, Mar 14, 3:48 PM
F15367476: D16368.diff
Tue, Mar 11, 6:52 PM
F15337717: D16368.diff
Sun, Mar 9, 7:18 AM
Unknown Object (File)
Sat, Mar 1, 7:46 AM
Unknown Object (File)
Feb 16 2025, 7:12 AM
Unknown Object (File)
Feb 9 2025, 2:07 AM
Unknown Object (File)
Feb 9 2025, 2:07 AM
Subscribers
None

Details

Summary

Fixes T7939. This doesn't get too fancy, but allows you to write Herald rules against Calendar events.

Test Plan
  • Wrote an "add red flag to events with party in the name" rule.
  • Created a "mundane meeting", didn't get flagged.
  • Created a "cool party", got flagged.
  • Ran rules from the Herald test console.

Diff Detail

Repository
rP Phabricator
Branch
calendar1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13245
Build 16975: Run Core Tests
Build 16974: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Add basic Herald support to Calendar.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2016, 12:03 AM
This revision was automatically updated to reflect the committed changes.