Page MenuHomePhabricator
Differential D16359

Fix Differental Filetree browser hotkey
ClosedPublic
Actions

Authored by chad on Aug 1 2016, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 7:03 PM
Unknown Object (File)
Tue, Jan 21, 9:52 AM
Unknown Object (File)
Fri, Jan 17, 4:45 AM
Unknown Object (File)
Dec 22 2024, 5:51 AM
Unknown Object (File)
Dec 19 2024, 6:43 PM
Unknown Object (File)
Dec 8 2024, 4:42 PM
Unknown Object (File)
Nov 28 2024, 3:14 AM
Unknown Object (File)
Nov 24 2024, 1:54 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
avivey
Commits
rPb53d38315f3f: Fix Differental Filetree browser hotkey
Summary

Adds a class for explicitly hiding the sidenav.

Test Plan

Set Config to Enable Filetree. View a diff, see tree. Press f, see it go away. Reload page, see persistence.

Diff Detail

Repository
rP Phabricator
Branch
diff-nav (branched from master)
Lint
Lint Skipped
Unit
Tests Passed
Build Status
Buildable 13227
Build 16949: Run Core Tests
Build 16948: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39348.Aug 1 2016, 8:59 PM
chad retitled this revision from to Fix Differental Filetree browser hotkey.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, avivey.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 1 2016, 8:59 PM
epriestley accepted this revision.Aug 1 2016, 9:16 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2016, 9:16 PM
Closed by commit rPb53d38315f3f: Fix Differental Filetree browser hotkey (authored by chad, committed by chad). · Explain WhyAug 1 2016, 9:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
32 lines
src/
view/
layout/
2 lines
webroot/
rsrc/
css/
aphront/
4 lines
js/
core/
1 line

Diff 39348

View Options

resources/celerity/map.php

Loading...
View Options

src/view/layout/AphrontSideNavFilterView.php

Loading...
View Options

webroot/rsrc/css/aphront/phabricator-nav-view.css

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-nav.js

Loading...
Phabricator · Built by Phacility