Page MenuHomePhabricator
Differential D16345

Fix task graph fatal for graphs containing restricted tasks
ClosedPublic
Actions

Authored by epriestley on Jul 29 2016, 2:03 PM.
Tags
None
Referenced Files
F15495619: D16345.diff
Sun, Apr 13, 5:13 AM
F15491616: D16345.diff
Sat, Apr 12, 5:32 AM
F15466398: D16345.id39306.diff
Thu, Apr 3, 5:05 AM
F15437986: D16345.id.diff
Tue, Mar 25, 10:30 PM
F15431425: D16345.diff
Mon, Mar 24, 12:16 PM
F15425284: D16345.id39307.diff
Sun, Mar 23, 3:48 AM
F15336221: D16345.diff
Mar 8 2025, 6:31 PM
Unknown Object (File)
Feb 16 2025, 7:10 AM
View All Files
Subscribers
• dunktang

Details

Reviewers
chad
Maniphest Tasks
T11392: Unhandled Exception when opening specific Task while not logged in
Commits
rP139e93916f97: (stable) Promote 2016 Week 31
rPbbc2ae78589b: Fix task graph fatal for graphs containing restricted tasks
Summary

Fixes T11392. If some tasks are restricted, we only have PHIDs for them, not objects. Just use the PHIDs instead.

Test Plan

Screen Shot 2016-07-29 at 7.02.29 AM.png (542×952 px, 70 KB)

Diff Detail

Repository
rP Phabricator
Branch
task7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13182
Build 16877: Run Core Tests
Build 16876: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39306.Jul 29 2016, 2:03 PM
epriestley retitled this revision from to Fix task graph fatal for graphs containing restricted tasks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11392: Unhandled Exception when opening specific Task while not logged in.
chad accepted this revision.Jul 29 2016, 2:21 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 29 2016, 2:21 PM
Closed by commit rPbbc2ae78589b: Fix task graph fatal for graphs containing restricted tasks (authored by epriestley, committed by epriestley). · Explain WhyJul 29 2016, 2:21 PM
This revision was automatically updated to reflect the committed changes.
• dunktang edited edge metadata.Jul 30 2016, 3:31 AM
• dunktang removed a task: T11392: Unhandled Exception when opening specific Task while not logged in.Jul 30 2016, 3:38 AM
• dunktang removed a commit: rPbbc2ae78589b: Fix task graph fatal for graphs containing restricted tasks.
• dunktang added a subscriber: • dunktang.
• dunktang added a task: T11392: Unhandled Exception when opening specific Task while not logged in.Jul 30 2016, 3:41 AM
• dunktang removed a task: T11392: Unhandled Exception when opening specific Task while not logged in.
epriestley added a task: T11392: Unhandled Exception when opening specific Task while not logged in.Jul 30 2016, 11:24 AM
epriestley added a commit: rPbbc2ae78589b: Fix task graph fatal for graphs containing restricted tasks.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
graph/
14 lines

Diff 39306

View Options

src/infrastructure/graph/ManiphestTaskGraph.php

Loading...
Phabricator · Built by Phacility