Page MenuHomePhabricator

Fix "Blocked" task queries with multiple subtasks, and update language
ClosedPublic

Authored by epriestley on Jul 28 2016, 5:21 PM.
Tags
None
Referenced Files
F15433126: D16340.diff
Mon, Mar 24, 9:36 PM
F15432185: D16340.id39294.diff
Mon, Mar 24, 4:40 PM
F15421295: D16340.id39298.diff
Fri, Mar 21, 10:24 PM
F15414707: D16340.id39294.diff
Thu, Mar 20, 2:03 AM
F15407102: D16340.diff
Mar 18 2025, 3:44 PM
F15390222: D16340.id.diff
Mar 15 2025, 6:02 AM
Unknown Object (File)
Mar 2 2025, 9:54 AM
Unknown Object (File)
Feb 16 2025, 7:10 AM
Subscribers
None

Details

Summary

Ref T8126. See that task for discussion. This change:

  • Updates language to be more consistent ("Parents", "Subtasks") since I moved us away from the often-confusing "Block" language in T4788.
  • Fixes bugs with finding the wrong set of tasks if tasks have a mixture of open and closed subtasks or parents.
Test Plan
  • Created four tasks: no subtasks, one closed subtask, one open subtask, mixture of open and closed subtasks.
  • Created four more tasks: no parents, one closed parent, one open parent, mixture of open and closed parents.
  • Searched for all this stuff, got the proper results:

Screen Shot 2016-07-28 at 10.14.13 AM.png (1×1 px, 222 KB)

Screen Shot 2016-07-28 at 10.11.46 AM.png (1×1 px, 193 KB)

Screen Shot 2016-07-28 at 10.14.07 AM.png (1×1 px, 223 KB)

Screen Shot 2016-07-28 at 10.11.49 AM.png (1×1 px, 193 KB)

Diff Detail

Repository
rP Phabricator
Branch
task1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13170
Build 16858: Run Core Tests
Build 16857: arc lint + arc unit