Page MenuHomePhabricator

Add a Packages application and PackagePublisher
ClosedPublic

Authored by epriestley on Jul 21 2016, 4:43 PM.
Tags
None
Referenced Files
F14320502: D16314.id39284.diff
Wed, Dec 18, 10:51 AM
F14317950: D16314.diff
Wed, Dec 18, 8:28 AM
F14295991: D16314.diff
Tue, Dec 17, 1:07 PM
Unknown Object (File)
Thu, Dec 12, 6:17 AM
Unknown Object (File)
Tue, Dec 10, 11:37 AM
Unknown Object (File)
Sat, Nov 30, 11:11 PM
Unknown Object (File)
Wed, Nov 27, 8:22 PM
Unknown Object (File)
Tue, Nov 26, 12:28 PM
Subscribers
None

Details

Summary

Ref T8116. Partially scavenged from D14152. This roughs in a new Packages application for Arcanist extensions and third-party applications, and adds a "Publisher" object.

A "Publisher" represents an individual or entity who is publishing a package, like "Phacility". It's explicitly not necessarily the original author -- just the primary entity vouching for the safety of the code.

A publisher just has a name and a unique key for now. For example, Phacility might have "Phacility" and "phacility", respectively.

Unique keys are immutable, e.g., the package "phacility/arcanist" will always be exactly the same package by exactly the same publisher.

Test Plan

Screen Shot 2016-07-21 at 9.12.26 AM.png (873×1 px, 158 KB)

Diff Detail

Repository
rP Phabricator
Branch
pack1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13160
Build 16843: Run Core Tests
Build 16842: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Add a Packages application and PackagePublisher.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

Kinda wonder if there will be some confusion with Owner Packages... Bundles? Dunno.

src/applications/packages/application/PhabricatorPackagesApplication.php
23



This revision is now accepted and ready to land.Jul 24 2016, 3:26 AM

(I plan to rename Owners Packages (possibly to "Claims") if we encounter confusion.)

epriestley edited edge metadata.
  • Use fa-gift.
This revision was automatically updated to reflect the committed changes.