Page MenuHomePhabricator

Give the Calendar month view a nice hover effect
ClosedPublic

Authored by epriestley on Jul 27 2016, 1:50 PM.
Tags
None
Referenced Files
F15455923: D16334.diff
Sun, Mar 30, 5:44 AM
F15440947: D16334.id.diff
Wed, Mar 26, 3:37 PM
F15438203: D16334.id39279.diff
Tue, Mar 25, 11:45 PM
F15434680: D16334.id39272.diff
Tue, Mar 25, 4:54 AM
F15433169: D16334.id39272.diff
Mon, Mar 24, 9:50 PM
F15428383: D16334.diff
Sun, Mar 23, 8:01 PM
F15386216: D16334.id39279.diff
Mar 15 2025, 12:11 AM
F15384520: D16334.id39272.diff
Mar 14 2025, 8:08 PM
Subscribers
None

Details

Summary

Ref T11326. Currently, we link Calendar days using hidden DOM nodes.

This is nice because it's simple, and right-clicking a day works properly. However, it's a bit ugly/unintuitive, messy, and unclear. It's especially messy because days are really two different rows, one for events and one for day/week numbers.

Instead, use JS to highlight day cells. You can still right-click by clicking the actual day number, which seems like a reasonable compromise.

Test Plan

Screen Shot 2016-07-27 at 6.44.23 AM.png (225×617 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Branch
cal2
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/calendar/behavior-month-view.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 13148
Build 16826: Run Core Tests
Build 16825: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Give the Calendar month view a nice hover effect.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2016, 3:49 PM
This revision was automatically updated to reflect the committed changes.